search

PRUNERS / archer

Archer, a data race detection tool for large OpenMP applications
https://pruners.github.io/archer
Apache License 2.0
62 stars 13 forks source link

Suppression for libarcher.sa #21

Closed simoatze closed 7 years ago

simoatze commented 7 years ago

Suppression for libomp.so and libarcher.so is made by the function in "__tsan_default_suppressions" or through a file declared using the TSAN_OPTION. In branch manage_clock the suppression.txt has been updated but we need to update also the function redefined automatically by clang-archer at compile time. Also the suppression.txt suppress ompt_tsan.so, however the new name should be libarcher.so.

simoatze commented 7 years ago

@dongahn Why this issue wasn't closed automatically? I put Resolve #21 in pull request body message (#19).

jprotze commented 7 years ago

I reallized, that this suppression was the cause for additional memory overhead. So, I reverted this change.

dongahn commented 7 years ago

Hmmm. I dont understand this one. The keywords are documented at help.github.com/articles/closing-issues-via-commit-messages

And yours seem right.

simoatze commented 7 years ago

@jprotze So you basically don't need to suppress libarcher.so?

dongahn commented 7 years ago

Perhals automatic closing just works when the changes makes into the default branch (master...)

jprotze commented 7 years ago

@simoatze suppression for libarcher is not needed.

simoatze commented 7 years ago

@jprotze So can I also modify the archer Pass and remove the redefinition of the tsan suppression function? Or do we still need the suppression?

jprotze commented 7 years ago

You can remove the suppression also from the archer pass