Closed simoatze closed 7 years ago
If $OMP_PREFIX/lib is where libarcher resides, this looks good to me.
@dongahn $OMP_PREFIX/lib is for the OpenMP library, for archer I added @LLVM_ROOT@/lib which is the path where archer will be installed.
We will also see if 'resolves #num ' will automatically close the issue upon merge!
Don't we need another rpath in the case or the rpath to LLVM_ROOT is already included somewhere?
I think you are right, I'll make an rpath like the one for the OpenMP lib.
I committed the fix, do I have to do a new PR and close this one without merging?
LGTM. What you can do is to squash the second commits to the first.
I typically do this with rebate -i SHA where SHA is the hash of the old commit.
Once you rewrite the commit history, you can force a push to the same branch where this PR came from. You may want to use this as an exercise?
I think I did it! :)
Cool! I will merge when ci smiles you with green :)
Oh one nit. Please revise the commit message so that we can track this change better in the future.
I fixed the commit message too (I am getting use to this rebase haha). Looks like the tests were successful.
Yeah, rebase is one of those magic tools that can make really clean traceable commit history with no intermediate state. Merging! Thanks.
@dongahn reopening, I think you didn't actually merge. I can't see the changes in towards_tr4 branch.
I actually did a mistake, I'll fix it and rebase.
I needed to add the include path for omp.h
. All should be good now.
my bad. Thanks.
…linking (when Archer is compiled with OMPT support). This resolves #23.