PRUNERS / archer

Archer, a data race detection tool for large OpenMP applications
https://pruners.github.io/archer
Apache License 2.0
62 stars 13 forks source link

Fixed wrapper, added path to header files and libarcher library when … #24

Closed simoatze closed 7 years ago

simoatze commented 7 years ago

…linking (when Archer is compiled with OMPT support). This resolves #23.

dongahn commented 7 years ago

If $OMP_PREFIX/lib is where libarcher resides, this looks good to me.

simoatze commented 7 years ago

@dongahn $OMP_PREFIX/lib is for the OpenMP library, for archer I added @LLVM_ROOT@/lib which is the path where archer will be installed.

dongahn commented 7 years ago

We will also see if 'resolves #num ' will automatically close the issue upon merge!

dongahn commented 7 years ago

Don't we need another rpath in the case or the rpath to LLVM_ROOT is already included somewhere?

simoatze commented 7 years ago

I think you are right, I'll make an rpath like the one for the OpenMP lib.

simoatze commented 7 years ago

I committed the fix, do I have to do a new PR and close this one without merging?

dongahn commented 7 years ago

LGTM. What you can do is to squash the second commits to the first.

I typically do this with rebate -i SHA where SHA is the hash of the old commit.

Once you rewrite the commit history, you can force a push to the same branch where this PR came from. You may want to use this as an exercise?

simoatze commented 7 years ago

I think I did it! :)

dongahn commented 7 years ago

Cool! I will merge when ci smiles you with green :)

dongahn commented 7 years ago

Oh one nit. Please revise the commit message so that we can track this change better in the future.

simoatze commented 7 years ago

I fixed the commit message too (I am getting use to this rebase haha). Looks like the tests were successful.

dongahn commented 7 years ago

Yeah, rebase is one of those magic tools that can make really clean traceable commit history with no intermediate state. Merging! Thanks.

simoatze commented 7 years ago

@dongahn reopening, I think you didn't actually merge. I can't see the changes in towards_tr4 branch.

simoatze commented 7 years ago

I actually did a mistake, I'll fix it and rebase.

simoatze commented 7 years ago

I needed to add the include path for omp.h. All should be good now.

dongahn commented 7 years ago

my bad. Thanks.