search

PRUNERS / archer

Archer, a data race detection tool for large OpenMP applications
https://pruners.github.io/archer
Apache License 2.0
62 stars 13 forks source link

Added flags to activate printing and reduce memory overhead #36

Closed simoatze closed 7 years ago

simoatze commented 7 years ago

Standardized flags management to activate debug prints (counters and max memory) and reduce memory overhead in between independent parallel regions.

jprotze commented 7 years ago

The changes look good to me. Travis for the initial PR failed, so I rerun it and it succeeded. I actually don't understand, why it failed in the specific test case.

Simone, please decide on Dong's wording suggestions and merge the pull request then.

simoatze commented 7 years ago

@dongahn it does not make me accept the review, I already made those changes though, please merge if everything looks good to you. Thanks!

dongahn commented 7 years ago

@simoatze: did you mean to change the wording for flush flag as well?

Our experiments show that this can reduce memory overhead by ~30% and runtime overhead by ~10%. This flag is useful for large OpenMP applications that typically require large amounts of memory, causing out-of-memory exceptions when checked by Archer.

simoatze commented 7 years ago

@dongahn Yeah I put your suggestion, is that ok?

dongahn commented 7 years ago

Sorry... what is the commit? I actually don't see that change.

simoatze commented 7 years ago

I thought I did it, can you see it now?

dongahn commented 7 years ago

Hmmm. Maybe I'm looking at the wrong commits. Is 71f4f7 the latest?

dongahn commented 7 years ago

Yeah, I see those now. Would it possible to squash intermediate commits? (rebase -i is your tool :-)

simoatze commented 7 years ago

@dongahn I rebased, but I think I squashed too much, it should be good though, let me know if it's ok.

simoatze commented 7 years ago

@dongahn I made a mess rebasing and now does not let me squash the message, I should probably close this PR and make a new one.

dongahn commented 7 years ago

Sure. Thanks. BTW, try to limit the commit title to 50 characters and add the main description into the commit message body.