search

PRUNERS / archer

Archer, a data race detection tool for large OpenMP applications
https://pruners.github.io/archer
Apache License 2.0
61 stars 13 forks source link

Update to 60 #62

Closed simoatze closed 6 years ago

simoatze commented 6 years ago
simoatze commented 6 years ago

@jprotze @dongahn when you guys have a minute to check this PR and merge it would be great. I am still having some issues to make it work on mac os, I have a linking problem where a flag "-no-deduplication" is added by clang to the ld command. I have the same problem with the OpenMP runtime so I wonder if I cmake the OpenMP runtime should I pass some specific flag. @jprotze do you know anything about it?

dongahn commented 6 years ago

@simone, I am in transit but I will try to get to this as soon as I have some time. Thank you for the effort. This is heroic!

simoatze commented 6 years ago

@dongahn sounds good, thanks! I tried to push and have a good version of Archer. As soon as this is merged I'll work with Ian to integrate his new feature to remove duplicates and we will be close to a new Archer release more stable and with new features! I'll be working on sword soon as well since we are getting closer to IPDPS.

dongahn commented 6 years ago

@simone, I added some comments here and there. In general, this looks great. This is a lot of work and what release number are you thinking about?

simoatze commented 6 years ago

@dongahn thanks for looking into this. I still need to add more tests for regression of bugs that I fixed. And I still can't make it work on MacOS (maybe @jprotze can take a look), I have no idea why it does not report the races on the racy tests. I was thinking Archer 2.0 since this are all major changes and it will be dependent to Clang 6.0.

dongahn commented 6 years ago

Yes. I was going to suggest the same thing on the versioning!

From: Simone Atzeni notifications@github.com Sent: Wednesday, April 11, 2018 8:53:00 AM To: PRUNERS/archer Cc: Ahn, Dong H.; Mention Subject: Re: [PRUNERS/archer] Update to 60 (#62)

@dongahnhttps://github.com/dongahn thanks for looking into this. I still need to add more tests for regression of bugs that I fixed. And I still can't make it work on MacOS (maybe @jprotzehttps://github.com/jprotze can take a look), I have no idea why it does not report the races on the racy tests. I was thinking Archer 2.0 since this are all major changes and it will be dependent to Clang 6.0.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/PRUNERS/archer/pull/62#issuecomment-380502936, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA0nq6BPBiXYmstV9CEyD8mfohICXI8jks5tnibcgaJpZM4TJdw_.

simoatze commented 6 years ago

I am merging this pull request, the tests are not passing because of a bug in the LLVM/Clang 6.0 binary. Since it's not possible to compile the trunk version on travis CI we need to wait for the next release to have Travis CI green again.