search

PRX / Infrastructure

Templates and assets used to launch and manage many aspects of PRX's applications and services
MIT License
42 stars 11 forks source link

Add hashed ip for Triton #693

Closed kookster closed 1 year ago

kookster commented 1 year ago

For #684 Not totally sure how to test this, but using a local script this seems to work ~, adding a single column for byte-range~ actually, they are fine with the separate start and end columns, they did ask for a hashed ip, so adding that instead.

Don't merge until we get confirmation they want the truncated ipv6 used for the hashed ip

farski commented 1 year ago

This is probably a better PR for @cavis, I've never looked at this code before. Seems reasonable to me though.

kookster commented 1 year ago

heard back from Triton today - they don't need the byte range as a new field, they do need the ip hashed - will do that instead.

kookster commented 1 year ago

triton also confirmed the ipv6 should be 64 bits (truncated) before hashing, like we do for the listenerid, so this is correct