PRX / Infrastructure

Templates and assets used to launch and manage many aspects of PRX's applications and services
MIT License
42 stars 11 forks source link

Move Spire templates #699

Closed farski closed 1 year ago

farski commented 1 year ago

This is to complete a bit of reorganization that started a while ago, and pulls our main CloudFormation templates under the spire/ directory.

This moves the files from stacks/… to spire/templates/….

The key changes are:

  1. Updating the TemplateURL used when creating change sets, which is hard-coded into the Lambda function that creates those change sets.
  2. Updating which files from the Infrastructure repo zip file get copied to S3
  3. Update the TemplateURL values for each nested stack in the root.yml template
  4. For nested stacks that continue to pass the S3 URLs of these templates down to more deeply nested stacks, also update the values being passed into TemplateUrlPrefix

There's not a lot of risk in this change. If CloudFormation looks for a file and it doesn't exist (because I made a mistake in updating these paths), the deploy will fail. The only real risk is that somehow a stack will update to an actual file, but not the template intended for that stack, and it will start to replace all the resources. That seems basically impossible, since all the file names are hard coded, and I don't think any overlap, and they would also have to exactly share parameters.