search

PRX / Play-Angular

Embed player
MIT License
11 stars 7 forks source link

Playback progress GA events have bad values #172

Open farski opened 7 years ago

farski commented 7 years ago

eg 30.000000000000004%, 29.999999999999993%, 810.0000000000001%, 1040%

The fractional values should get rounded.

All values should be three digits (eg 030%)

Not sure what's going on with the values > 1

gcampo88 commented 7 years ago

@farski can you add a screenshot or link to the view you're looking at? when I look, I see playback events but the value for all of them is 0.00%. image

farski commented 7 years ago

screen shot 2017-11-06 at 4 02 02 pm

gcampo88 commented 7 years ago

compare to code in radio.radiotopia.fm, which is not having this issue https://github.com/PRX/radio.radiotopia.fm/blob/23d9730d3d2c94bf275826302dab70ff02a251ce/main.js