The MergeAdapter requires a certain number of params, before the Observable will return. This causes the player to silently "load" forever when we can't find all the params.
We need to keep some of these required params. The purpose of the merge adapter is to make sure we don't leave the loading state too soon, when there are multiple data sources. For instance, if you specified the title in the query param ?tt=whatever, but also loaded the RSS feed for the rest of the data, we need to wait for that feed to load before rendering.
Several TODOs here:
[ ] console.error from the MergeAdapter after X seconds pass and we're still missing a required parameter. (Long enough that we're sure the feed / draper have loaded).
[ ] Only title and audioUrl are required.
[ ] Render blank subtitle by default
[ ] Have a default image in this codebase for the feedArtworkUrl. Also some sort of default background.
[ ] Hide subscribe button if subscribeUrl is not present
The MergeAdapter requires a certain number of params, before the Observable will return. This causes the player to silently "load" forever when we can't find all the params.
We need to keep some of these required params. The purpose of the merge adapter is to make sure we don't leave the loading state too soon, when there are multiple data sources. For instance, if you specified the title in the query param
?tt=whatever
, but also loaded the RSS feed for the rest of the data, we need to wait for that feed to load before rendering.Several TODOs here: