search

PRX / Play-Angular

Embed player
MIT License
11 stars 7 forks source link

Export the DovetailAudio class as a named export #179

Closed binarynate closed 6 years ago

binarynate commented 6 years ago

Greetings! We're preparing to update play.radiopublic.com to add features that make it easy to switch back and forth between the web and our native apps, and as part of that, I'll be creating a player that integrates with those features. Chris asked that I utilize this project's DovetailAudio class in the new player, so this PR adds two lines of code to export that class. I've verified that with this change, we can import and compile the class in our project using ts-loader. I'm definitely open to other ways of exposing this class if you prefer a different approach, so please let me know what you think.

binarynate commented 6 years ago

Thanks, @gcampo88 . What do you think is the next step? Should someone else also approve, or is it OK to merge this? I don't have access to merge it, so I'll someone else to trigger that.