This removes the last remaining guard left from #904 and #853. This guard was using the "old" sentinel value of the delivery and delivery files themselves. But as we have come to understand, those records are ephemeral in Apple's Delegated Delivery API, and per #1022 we don't want to mutate state outside the publishing pipeline locks .
Closes #1022
This removes the last remaining guard left from #904 and #853. This guard was using the "old" sentinel value of the delivery and delivery files themselves. But as we have come to understand, those records are ephemeral in Apple's Delegated Delivery API, and per #1022 we don't want to mutate state outside the publishing pipeline locks .
Looking at the episode publishing hook: https://github.com/PRX/feeder.prx.org/blob/f7e9cda2c85ae852a18b33987477450c77a0ad78/app/models/episode.rb#L264-L269
With this PR, the only mutation that occurs with Episode#publish is:
Episode#apple_statuslog entry indicating that the episode needs to be (re-)delivered