Feat/transcripts UI - Githubissues

radical-ube commented 1 month ago

resolves #1060

New UI for transcripts uploading at episode_media_path. Code is mostly ported as a mix from media upload and image upload elements; code organization and visual should look most similar to an audio/video upload.

functionality testing:

does a transcript upload work?
are allowed file types correctly permitted/blocked from upload?
upon episode save, is the transcript properly built and saved in the db?
for a complete upload, is the download button working properly?
for a complete upload, is the delete button working properly?
does an error display as intended?

@cavis for functional and code review @brandonhundt for visual/styling/UI review

brandonhundt commented 3 weeks ago

One more thought. I don't think we should support PDFs. That is outside the spec of supported file types here: https://github.com/Podcastindex-org/podcast-namespace/blob/main/transcripts/transcripts.md

radical-ube commented 3 weeks ago

Great start! Initial UI thoughts:

I don't think transcripts need to be in their own card especially if its only a single field. I think in its current form users will get a little confused and put their audio in the transcripts field - they seem a little of the same priority. (Aside- long term I think transcripts will be in their own tab)

@brandonhundt 2 responses: first, unless I have not restricted it properly, a user shouldn't be able to upload any file formats other than what is currently accepted, meaning only text, json, and pdf are currently what's allowed in that field. if you are able to upload audio to that field, then i have to double check the restrictions.

second, any opposition to just creating the new Transcripts tab now and moving this field there? while it does seem silly to only have the one field in there for the moment, i think it sets up the expectation that there would be more in that tab in the future, such as a Transcript Editor tool, or multiple transcript uploads.

brandonhundt commented 2 weeks ago

@radical-ube Since there's not a design file for the tabbed interface, yet, I've given you some inline feedback. I think this will work well and set some solid UX patterns as we add more features in the future.

Also thanks for removing PDF uploads!

brandonhundt commented 2 weeks ago

@radical-ube Thanks for the latest changes, it's looking outstanding and working as intended! One last thing I just noticed...

In the Status box, the updated date should be in a column next to the button. We had to change it in the Media Files status box because of some extra buttons and badges, but because those don't exist for this tab, we should use the other style that's present throughout the app. Very minor. Thanks.

Existing:

Expected:

PRX / feeder.prx.org

Feat/transcripts UI #1075