search

PSAppDeployToolkit / PSAppDeployToolkit

Project Homepage & Forums
https://psappdeploytoolkit.com
GNU Lesser General Public License v3.0
1.78k stars 474 forks source link

DeploymentType 'Uninstall' Still Uses "Install/Installing" wording in prompts #748

Open ceasley112 opened 1 year ago

ceasley112 commented 1 year ago

Describe the bug When using the parameter -DeploymentType 'Uninstall', any prompts still use the terms "Install" or "Installing" for software actions. Specifically, the "Show-InstallationRestartPrompt" and "Show-InstallationWelcome" functions.

image image

If possible, these (and other) dialogs should reflect correct wording when performing an "Uninstall" vs. performing an "Install"

Screenshots If applicable, add screenshots to help explain your problem.

Toolkit Version: 3.9.1

Powershell Version: 5.1

Howard0101 commented 1 year ago

I propose this change in the following XML where the wording comes from: AppDeployToolkitConfig.zip

Here I exchanged the wording for example for 'install' to 'un-/install' since both is possible. This way no powershell code has to be changed. Eventhough it is more of a workaround and the optimal change should be in distinguishing the different ways of 'install', 'uninstall' and 'repair' in the proper wording. This change in code would be annoying work and beautifies only cosmetics. I guess one will need a lot more variables for textblocks.

Note: I ONLY changed the original english and the german translation since I am fluent in both. The other languages still need to be adapted.

Howard0101 commented 1 year ago

I just noticed another issue with the same problem:

41

So this seems to be a dupe. Still my workaround would apply.