PSC-PublicHealth / HERMES

0 stars 0 forks source link

Issue 95 #108

Closed pthompk3 closed 5 years ago

pthompk3 commented 5 years ago

Changes are all in src/ui_server/views/model_create_provision.tpl. Values input on What Equipment And Population Exist At Each Level? are now guaranteed to be nonnegative integers, with clear errors thrown and red highlighting for cells with bad data.

Issue: https://github.com/PSC-PublicHealth/HERMES/issues/95

shots47s commented 5 years ago

The COPYRIGHT.txt file should go in the top level directory rather than the docs directory.

pthompk3 commented 5 years ago

I checked out from the Release_1.0 branch and I'm not seeing a docs directory or COPYRIGHT.txt. There's a LICENSE.txt in src though, if that's what you mean?

shots47s commented 5 years ago

It was part of this pull request, I think Xuth did it. This is a rather long pull request and seems that it may have captured a whole lot of commits that were done prior. At some point, Xuth removed the Copyright text from all source files and put it in docs.

pthompk3 commented 5 years ago

I've double-checked the files on my end and the Copyright text has been removed from source files, and github says there's only one file getting changed. I noticed after your first comment that the base branch was set as master instead of Release_1.0, so that's fixed- let me know if that changes anything.