PSDev / LicensesDialog

LicensesDialog is an open source library to display licenses of third-party libraries in an Android app.
http://psdev.de/LicensesDialog
Apache License 2.0
850 stars 145 forks source link

Change License URLs from http:// to https:// #82

Closed jpstotz closed 7 years ago

jpstotz commented 7 years ago

I noticed that all the license implementations in de.psdev.licensesdialog.licenses return the insecure http:// urls when calling getUrl(). From my perspective the urls should be changed to https:// as all the major version provider like Mozilla, Eclipse, Apache, ... have changed their primary site to https:// - therefore IMHO the urls in this library should be adapted, too.

jpstotz commented 7 years ago

Addendum: This also applies to the psdev url in class de.psdev.licensesdialog.LicensesDialog new Notice("LicensesDialog", "http://psdev.de/LicensesDialog", ...

hameno commented 7 years ago

Good Idea, would you be willing to create a Pull Request?

jpstotz commented 7 years ago

Sorry I can't do that.