search

PSIAIMS / CAMIS

https://psiaims.github.io/CAMIS/
Apache License 2.0
55 stars 51 forks source link

Create PCA_analysis.qmd #245

Closed royano19 closed 2 months ago

royano19 commented 2 months ago

Performing PCA Analysis

thisisnic commented 2 months ago

I'll give this an initial review shortly!

thisisnic commented 2 months ago

This is a great start! The code chunks in here look like they're missing the backticks (```) to indicate the start and end of code chunks and also the heading tags (e.g. #) for some of the text. Mind adding those in please @royano19 ?

royano19 commented 2 months ago

This is a great start! The code chunks in here look like they're missing the backticks (```) to indicate the start and end of code chunks and also the heading tags (e.g. #) for some of the text. Mind adding those in please @royano19 ?

Sure Let me check

thisisnic commented 2 months ago

The build is failing as we have a couple of missing package dependencies, but we can take a look at making a PR to your fork to update this as it's a little but of a weird process. Will ping once we have something together! @ines-gimeno-molina is taking a look! :)

royano19 commented 2 months ago

yes I donno first time it is passing all the checks but now it's not working. strange

ines-gimeno-molina commented 2 months ago

Hello! @royano19 @thisisnic i created a PR with the changes to the renv.lock that should fix the issue. https://github.com/royano19/CAMIS/pull/2 @royano19 if you merge it, you'll see the changes in this PR to the original CAMIS repo

royano19 commented 2 months ago

@ines-gimeno-molina @thisisnic I have merged. Now what else I need to do?

ines-gimeno-molina commented 2 months ago

The checks are now passing @royano19 @thisisnic

royano19 commented 2 months ago

Thanks @ines-gimeno-molina . @thisisnic you can have a review.