search

PSJahn / blurredwindow

GNU General Public License v3.0
9 stars 2 forks source link

Small improvements #5

Closed EnderKill98 closed 5 months ago

EnderKill98 commented 5 months ago

Hi again :D

Just some small changes, that i think are worth adding:

Fix disabling BlurBehind on X11

Seems my assumption that the value of _KDE_NET_WM_BLUR_BEHIND_REGION is a boolean, was false. It's either some magic value, some other weird usage or it's just plainly ignored. I changed it to remove the property, when disabling the blur behind effect is requested. This seems to properly work as I tested running the method XLib.setBlurBehind from my mod during runtime now (where it wouldn't do anything before):

BlurBehind On (unchanged):

screenshot0005-37

BlurBehind Off:

screenshot0005-38

Small mixin tweak

I also changed one mixin to use @WrapOperation instead of @Redirect. Mixin-Extras is nowadays builtin to fabric and it seems recommended to prefer using that operation as it can be chained. See Wiki

The other mixins that do redirect, don't need to be updated as @WrapOperation is not useful if the original method is never intended to be called anyway.

Again worth mentioning: This mod is awesome! It really makes Minecraft feel modern in a very unique way!

PSJahn commented 5 months ago

Thanks for the support on this project! Merging now.