PSLmodels / Business-Taxation

USA Corporate and Pass-Through Business Tax Model
11 stars 10 forks source link

Refactor responses #55

Closed codykallen closed 5 years ago

codykallen commented 5 years ago

This PR refactors the investment response (a mini version of B-Tax, with somewhat different equations and measures). With this PR, the investment and debt responses are both functional. And with the legal response still left as doing nothing (until I refactor it based on a more sound economic basis), the responses are now usable. Accordingly, I have updated example.py to include the responses.

As part of making the responses functional, this PR also does some minor debugging on the components of the various classes that handle responses.

This PR does not affect the test results, which used static analysis. It also does not add new tests for the responses.

I believe it is important to note that the calculation of the responses is the most time-intensive portion of the model.

@martinholmer