This PR eliminates the separate treatment of "special" one-time changes by merging them into the main object with policy parameters. The new treatment is capable of modeling the old "special" parameters, with some additional flexibility. It is important to note that this additional flexibility may be convenient for static analysis, but it is potentially subject to abuse when dealing with the responses. Further thought should be given to refactoring the debt response and the investment response to account for the haircuts.
This PR also eliminates the reclassify_gds_life and reclassify_ads_life provisions. Although these could be useful (and were contemplated in some of the TCJA debate), their implementation is subpar, an obstacle to refactoring, and not integral to most calculations.
I also fixed a small error when calculating net interest, which I had identified when doing the previous major refactoring.
This PR eliminates the separate treatment of "special" one-time changes by merging them into the main object with policy parameters. The new treatment is capable of modeling the old "special" parameters, with some additional flexibility. It is important to note that this additional flexibility may be convenient for static analysis, but it is potentially subject to abuse when dealing with the responses. Further thought should be given to refactoring the debt response and the investment response to account for the haircuts.
This PR also eliminates the
reclassify_gds_lifeandreclassify_ads_lifeprovisions. Although these could be useful (and were contemplated in some of the TCJA debate), their implementation is subpar, an obstacle to refactoring, and not integral to most calculations.I also fixed a small error when calculating net interest, which I had identified when doing the previous major refactoring.