search

PSLmodels / Business-Taxation

USA Corporate and Pass-Through Business Tax Model
11 stars 10 forks source link

Reorganize and add files that will allow the creation of biztax conda packages #58

Closed martinholmer closed 5 years ago

martinholmer commented 5 years ago

This is the first of several sets of (non-substantive) changes that are required in order to be able to make conda biztax packages from the source code and data in the Business-Taxation repository.

This pull request moves code and data files into the new biztax subdirectory and adds the biztax/__init__.py file that specifies what can be imported from the biztax package. It also uses the standard os.path.join method of constructing absolute paths for each data file. The import of Business-Taxation objects into the top-level example.py and test_brc.py files has also been changed.

And most importantly, the python test_brc.py command still produces all PASS messages and the python example.py command still produces the exact same results in the test_results/ex_out[12].csv files.

codykallen commented 5 years ago

@martinholmer, thanks for these changes. They look fine to me, indeed with no substantive changes. Are you planning to make any further changes in this PR, or should we merge this?

martinholmer commented 5 years ago

@codykallen said in Business-Taxation PR #58:

thanks for these changes. They look fine to me, indeed with no substantive changes. Are you planning to make any further changes in this PR, or should we merge this?

I'm planning a sequence of pull requests in order to make the overall revisions a little easier to understand. So, after further review and contemplation, go ahead with a merge if you're comfortable with these changes.