search

PSLmodels / Business-Taxation

USA Corporate and Pass-Through Business Tax Model
11 stars 10 forks source link

Use new Policy class in Business-Taxation logic #82

Closed martinholmer closed 5 years ago

martinholmer commented 5 years ago

This pull request make changes in the Business-Taxation code to use the new Policy class introduced in PR #81. The goal of these changes is to use the Policy class in all the biztax modules and in all the tests and in the example.py script without experiencing any changes in test or example results.

The development branch containing the changes code changes is built on top of the policy-add branch contained in PR #81.

Given the changes in this PR, the revised example.py script (which now uses the new Policy class) produces exactly the same example results as does the code on the master branch (which does not use the new Policy class). In order to accomplish this, the businessmodel.py and investor.py code had to be revised to use the new Policy class. Also, the unit tests all execute smoothly using the new Policy class (see changes to the tests/conftest.py file). However, some, but not all, of the unit test results are now different. The cause of these unit test results differences are currently being investigated.

martinholmer commented 5 years ago

@codykallen, PR #82 now includes all the recent changes on the master branch (from the merge of PR #84) as well as all the changes in PR #81 and PR #83 (both of which have been closed as redundant).

All the tests pass. So, this PR #82 is ready for your final review.

codykallen commented 5 years ago

@martinholmer, these changes look good to me.