PSLmodels / Cost-of-Capital-Calculator

A cost of capital and effective tax rate calculator

https://ccc.pslmodels.org

Other

17 stars 33 forks source link

Update retrieve_puf function #349

Closed jdebacker closed 3 years ago

jdebacker commented 3 years ago

This PR updates the retrieve_puf function used in the Compute Studio app to access the PUF.

cc @hdoupe

codecov-io commented 3 years ago

Codecov Report

Merging #349 (5d1f75b) into master (eb3ad19) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #349   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1104      1104           
=========================================
  Hits          1104      1104

Flag	Coverage Δ
unittests	`100.00% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

jdebacker commented 3 years ago

@hdoupe Please review this and let me know if it's good to merge. Thanks!

hdoupe commented 3 years ago

@jdebacker I'm testing this locally now. Thanks for pulling the changes from my pr over. Will report back when the tests are done.

hdoupe commented 3 years ago

@jdebacker LGTM! Tests pass locally and am able to read the PUF file.

jdebacker commented 3 years ago

Thanks @hdoupe! Merging now -- feel free to update app whenever.

hdoupe commented 3 years ago

@jdebacker this is live on CCC now and working as expected!