PSLmodels / Cost-of-Capital-Calculator

A cost of capital and effective tax rate calculator
https://ccc.pslmodels.org
Other
17 stars 33 forks source link

Updates for new cs kit #357

Closed jdebacker closed 3 years ago

jdebacker commented 3 years ago

This PR makes a couple modifications for the cs-config files to work with the lates cs-kit.

@hdoupe -- It looks like the latest cs-kit will fix the bokeh plot rendering issues on C/S:

 cs_kit.exceptions.CSKitError: "Bokeh outputs must be created with json_item. Reference: https://docs.compute.studio/publish/outputs/#bokeh"

Is that correct?

codecov-commenter commented 3 years ago

Codecov Report

Merging #357 (01b97b0) into master (53246a1) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #357   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1109      1109           
=========================================
  Hits          1109      1109           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

hdoupe commented 3 years ago

LGTM, @jdebacker !