search

PSLmodels / Cost-of-Capital-Calculator

A cost of capital and effective tax rate calculator
https://ccc.pslmodels.org
Other
17 stars 33 forks source link

Improve variable and parameter name consistency #360

Closed duncanhobbs closed 3 years ago

duncanhobbs commented 3 years ago

This PR attempts to improve variable name consistency by replacing nc with pt and corp with c.

codecov-commenter commented 3 years ago

Codecov Report

Merging #360 (ccc32aa) into master (c1296dc) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #360   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1109      1109           
=========================================
  Hits          1109      1109
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ccc/controls_callback_script.py 100.00% <ø> (ø)
ccc/calculator.py 100.00% <100.00%> (ø)
ccc/get_taxcalc_rates.py 100.00% <100.00%> (ø)
ccc/parameters.py 100.00% <100.00%> (ø)
ccc/paramfunctions.py 100.00% <100.00%> (ø)
jdebacker commented 3 years ago

@duncanhobbs Thank you for updating the parameter names!