PSLmodels / Cost-of-Capital-Calculator

A cost of capital and effective tax rate calculator
https://ccc.pslmodels.org
Other
17 stars 33 forks source link

Remove Unused Dependency: psutil #377

Closed gdrosos closed 1 year ago

gdrosos commented 1 year ago

Summary

This pull request removes the unused dependency psutil from the setup.py configuration file . This detection and removal is a finding from ongoing research aimed at identifying and eliminating code bloat within software projects.

Rationale

The psutil library was introduced in a6d60a7e. However, an examination of the current codebase revealed that it is not used within the project. Removing this unused dependency can reduce the overall footprint of the application, mitigate potential security risks, and simplify the dependency management process.

Changes

Impact

gdrosos commented 1 year ago

Hello @rickecon, @jdebacker

I hope this message finds you well. We are currently engaged in a research project focused on optimizing projects by identifying and eliminating unnecessary dependencies. Your insights and expertise as maintainers would greatly contribute to our research efforts.

Could you please take a moment to review these changes? Your input would be highly valuable to us.

Thank you for your consideration!

jdebacker commented 1 year ago

@gdrosos I saw an error in the units tests run under CI with this PR. I've fixed those in PR #378.

Can you sync to the master branch and then this PR should pass tests and I will merge.

Thanks!

gdrosos commented 1 year ago

Thanks @jdebacker, I just synced the fork to the master branch

jdebacker commented 1 year ago

Thanks for this PR @gdrosos! Merging.