search

PSLmodels / OG-Core

An overlapping generations model framework for evaluating fiscal policies.
https://pslmodels.github.io/OG-Core/
Creative Commons Zero v1.0 Universal
65 stars 112 forks source link

Consolidation and consistency in "outer loop" variables #452

Closed jdebacker closed 5 years ago

jdebacker commented 5 years ago

This issue documents a point raised by @rickecon that OG-USA has some inconsistencies in the GE loop variables.

In particular, SS.SS_fsolve() and SS.SS_solver() can have if-statements consolidated and can use T_H in the set of variables used to determine a general equilibrium, except for in the base of baseline_spending=True, in which case, Y will replace T_H in the set of GE variables.

Relatedly, the GE loop in the TPI.run_TPI() includes w in the computation of TPI_dist. w should be removed from this calculation since it is pinned down by r.

jdebacker commented 5 years ago

This issue was resolved with PR #455