PSLmodels / OG-Core

An overlapping generations model framework for evaluating fiscal policies.
https://pslmodels.github.io/OG-Core/
Creative Commons Zero v1.0 Universal
65 stars 111 forks source link

Updated the version #898

Closed rickecon closed 7 months ago

rickecon commented 7 months ago

This PR:

cc: @jdebacker

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (42cd461) 80.52% compared to head (1c9f284) 80.52%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/PSLmodels/OG-Core/pull/898/graphs/tree.svg?width=650&height=150&src=pr&token=98mQCVhspd&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels)](https://app.codecov.io/gh/PSLmodels/OG-Core/pull/898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) ```diff @@ Coverage Diff @@ ## master #898 +/- ## ======================================= Coverage 80.52% 80.52% ======================================= Files 19 19 Lines 4452 4452 ======================================= Hits 3585 3585 Misses 867 867 ``` | [Flag](https://app.codecov.io/gh/PSLmodels/OG-Core/pull/898/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PSLmodels/OG-Core/pull/898/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | `80.52% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/PSLmodels/OG-Core/pull/898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [ogcore/\_\_init\_\_.py](https://app.codecov.io/gh/PSLmodels/OG-Core/pull/898?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#diff-b2djb3JlL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | |
rickecon commented 7 months ago

@jdebacker. This PR is ready to go.

rickecon commented 7 months ago

@jdebacker. My ogcore-dev conda environment originally had the black package version 23.?.?. I noticed that when I ran it, it had me update two files to which I made no changes: firm.py and txfunc.py. These formatting changes caused those two files to fail the GH Action "Check Black formatting". I noticed in the GH Action log for the "Check Black formatting" tests that it was loading black version 24.1.1.

I deleted my ogcore-dev conda environment and reinstalled it, which produced an environment with the updated black version 24.1.1. Because the old black version 23.?.? gives results that are different from version 24.1.1, I recommend that we set the black version in environment.yml to be >=24.1.1. I have done this in my most recent commit.

jdebacker commented 7 months ago

@rickecon Thanks for this PR. LGTM. Merging.