Closed rickecon closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
42cd461
) 80.52% compared to head (1c9f284
) 80.52%.
@jdebacker. This PR is ready to go.
@jdebacker. My ogcore-dev
conda environment originally had the black
package version 23.?.?. I noticed that when I ran it, it had me update two files to which I made no changes: firm.py
and txfunc.py
. These formatting changes caused those two files to fail the GH Action "Check Black formatting". I noticed in the GH Action log for the "Check Black formatting" tests that it was loading black
version 24.1.1.
I deleted my ogcore-dev
conda environment and reinstalled it, which produced an environment with the updated black
version 24.1.1. Because the old black
version 23.?.? gives results that are different from version 24.1.1, I recommend that we set the black
version in environment.yml
to be >=24.1.1. I have done this in my most recent commit.
@rickecon Thanks for this PR. LGTM. Merging.
This PR:
setup.py
andogcore/__init__.py
CHANGELOG.md
fileLICENSE.md
for the official CC0-1.0LICENSE
file. This way, the license type shows up on our main page right-hand-side licenseREADME.md
and added them to the beginning of theintro.md
page of the documentationcc: @jdebacker