Closed rickecon closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
0866c09
) 80.52% compared to head (72ee2bd
) 80.52%.
@jdebacker. This PR is ready for review. It is a small change.
Thanks for looking at this @rickecon.
This seems like it relates to Issue #889.
Because it maybe helpful going forward (i.e., making sure OG-Core is compatible with 3.12+), can you document in this PR or that issue what were the problems you noticed with the ogcore
package in Python 3.12?
@jdebacker. I never verified that the errors I was getting in OG-USA were coming from Python 3.12. But the principle is that if we are restricting it in the environment.yml
file, we need to also restrict it in the setup.py
file.
I think we should lift that restriction or move it to <3.13
as soon as possible. But we should only do that with testing.
This PR updates the Python version requirements in
setup.py
to bepython_requires=">=3.7.7, <3.12"
. The new addition is the<3.12
piece. This requirement is inenvironment.yml
. However, when OG-Core is pip installed, it usessetup.py
and will sometimes install Python 3.12. The PR makes the Python version always be < 3.12.cc: @jdebacker