Closed jdebacker closed 4 months ago
Local testing found the following failures, but I think they are expected on a different platform than the cashed results where estimated on:
FAILED tests/test_txfunc.py::test_txfunc_est[DEP] - assert False
FAILED tests/test_txfunc.py::test_txfunc_est[GS] - assert False
FAILED tests/test_txfunc.py::test_tax_func_loop - assert False
FAILED tests/test_txfunc.py::test_tax_func_estimate - assert False
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.44%. Comparing base (
8f1d770
) to head (420b815
).
@jdebacker. I had three test_txfunc.py
tests fail on my machine locally on TJ's PR #925. And I just got the same three failures when I ran the tests on this branch. So this is just something we need to fix in the txfunc.py
module.
FAILED tests/test_txfunc.py::test_txfunc_est[DEP] - assert False
FAILED tests/test_txfunc.py::test_tax_func_loop - assert False
FAILED tests/test_txfunc.py::test_tax_func_estimate - assert False
@jdebacker. Looks great. Merging.
This PR removes some unused arguments in functions in the
txfunc.py
module. It also removes reference to Tax-Calculator since this module is agnostic to the microsimulation model used to generate average and marginal tax rates.