Closed rickecon closed 3 years ago
I commented out the - git+https://github.com/PSLmodels/openfisca-uk
line in environment.py
, cleared any old oguk-dev
conda environment material, and created the new oguk-dev
environment. Everything went well and smoothly, although it took 26 minutes (2 minutes for the initial environment dependencies and 24 minutes for the pip install of OG-Core
). But it worked. So the conflict is definitely being generated by the pip install of openfisca-uk
.
@jdebacker @nikhilwoodruff @MaxGhenis @jpycroft
@rickecon Thanks for this detailed report and for drilling down on the source of the errors.
I'm getting the same errors your report when I try to create the environment on my machine (running Mac OS 11.5.2). Note that in PR #22, the GH Actions were able to build the environment without problem on Linux and Windows.
matrix.os
in the OG-UK GH Action?@jdebacker
@rickecon I should be able to test this later, but at first glance it looks like the (or at least one) issue is that the Python version is 3.9 - currently we're only building OpenFisca-UK on 3.7.7, so might need to add a <= condition in the version requirement?
@rickecon asks:
Should we add OSX to the matrix.os in the OG-UK GH Action?
Unfortunately, adding OS X to the testing matrix isn't straight-forward (see this Tax-Calculator PR for discussion and links to more info).
Per @nikhilwoodruff's suggestion, I set python<=3.7.11
and my environment built and I can create the oguk
package and run the model.
@rickecon Can you try again using the main
branch now that I've merged PR #29?
@jdebacker @rickecon @nikhilwoodruff
Hi Jason,
I’ve been trying out the new oguk-dev environment and (drum roll please … ) it installs! The conda activate oguk-dev worked fine. And no errors with the “pip install -e .” I've attached the conda output below.
Then I thought I’d try to run the example “python run_oguk.py” in the “examples/” folder. This generated over 5000 lines of errors. Many errors reference matplotlib (I checked that my matplotlib is up-to-date, of course). I've also attached that output below.
Best, Jon
@jpycroft Thank you for the report!
I'll close this issue (since you were able install the environment). And I'll take a look at the tracebacks from your trying to run the example. I'll also open up an issue to discuss that.
In the new repo with its dependencies on
OG-Core
andOpenFisca-UK
, I cannot get the conda environment to create. The condaenvironment.yml
file has twopip
imports that are likely causing the problem.My
conda env create -f environment.yml
command ran for 30 minutes in my terminal, then errored out with the following long set of messages, with the concluding messageCondaEnvException: Pip failed
.IDENTIFIED PROBLEMS Reading through all the messages, I have identified 7 possible problems causing this environment to fail. Some of them might be interrelated:
colorama
package takes a long time to analyze compatibility with requirements.colorama
package version compatibility search, I get aPip subprocess error:
sayingERROR: Command errored out with exit status 1:
after trying to cloneOG-Core
,openfisca-uk
,openfisca-uk-data
,microdf
, andsynthimpute
. I suspect that thecolorama
package is a dependency of at least one of these five packages and is causing a conflict with another of them.hdf5
ERROR: Command errored out with exit status 1:
occurs with install offrom https://pypi.org/simple/tables/) (requires-python:>=3.5)
cpuinfo
packagenumpy>=1.4.1
might need to be a dependency because ofPyTables
:ERROR:: You need numpy 1.4.1 or greater to run PyTables!
setup.py
files@jdebacker @nikhilwoodruff @MaxGhenis @jpycroft