PSLmodels / OG-UK

An overlapping generations model to simulate fiscal policy the United Kingdom.
https://pslmodels.github.io/OG-UK
Other
6 stars 7 forks source link

Microsimulation fixes #35

Closed nikhilwoodruff closed 2 years ago

nikhilwoodruff commented 2 years ago

This PR:

nikhilwoodruff commented 2 years ago

Here are the outputs produced by examples/plot.py now (the tax functions in 3D plots): image image image

codecov[bot] commented 2 years ago

Codecov Report

Merging #35 (6a148c1) into main (857532c) will increase coverage by 17.26%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #35       +/-   ##
===========================================
+ Coverage   45.85%   63.12%   +17.26%     
===========================================
  Files           6        4        -2     
  Lines         205      141       -64     
===========================================
- Hits           94       89        -5     
+ Misses        111       52       -59     
Flag Coverage Δ
unittests 63.12% <100.00%> (+17.26%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oguk/get_micro_data.py 70.96% <100.00%> (-5.35%) :arrow_down:
oguk/tests/test_get_micro_data.py 87.50% <100.00%> (+3.62%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 857532c...6a148c1. Read the comment docs.

jdebacker commented 2 years ago

@nikhilwoodruff Thanks for this PR. LGTM. Merging.