PSLmodels / OG-UK

An overlapping generations model to simulate fiscal policy the United Kingdom.
https://pslmodels.github.io/OG-UK
Other
6 stars 7 forks source link

Update budget window #47

Closed nikhilwoodruff closed 2 years ago

nikhilwoodruff commented 2 years ago

OpenFisca-UK now only supports the 2022-27 budget window, dropping support for 2019-21. This updates all references and logic using the old budget window. Also ensures the OpenFisca-UK code runs locally (for me, soon hopefully for @jpycroft).

codecov[bot] commented 2 years ago

Codecov Report

Merging #47 (54846f0) into main (d911ee7) will increase coverage by 2.81%. The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
+ Coverage   63.15%   65.97%   +2.81%     
==========================================
  Files           6        6              
  Lines         323      335      +12     
==========================================
+ Hits          204      221      +17     
+ Misses        119      114       -5     
Flag Coverage Δ
unittests 65.97% <90.90%> (+2.81%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
examples/run_oguk.py 57.35% <ø> (ø)
setup.py 0.00% <0.00%> (ø)
oguk/get_micro_data.py 92.64% <88.88%> (+7.35%) :arrow_up:
oguk/tests/test_get_micro_data.py 87.50% <100.00%> (+5.35%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d911ee7...54846f0. Read the comment docs.

nikhilwoodruff commented 2 years ago

@jdebacker just got the tests passing - OK to merge?

rickecon commented 2 years ago

Looks great to me. Thanks @nikhilwoodruff and @jdebacker.