Closed rickecon closed 2 years ago
Thanks @rickecon!
Merging #48 (99ff935) into main (e08994c) will decrease coverage by
0.78%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 63.94% 63.15% -0.79%
==========================================
Files 4 6 +2
Lines 147 323 +176
==========================================
+ Hits 94 204 +110
- Misses 53 119 +66
Flag | Coverage Δ | |
---|---|---|
unittests | 63.15% <ø> (-0.79%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
oguk/get_micro_data.py | 85.29% <ø> (+13.23%) |
:arrow_up: |
oguk/tests/test_get_micro_data.py | 82.14% <ø> (-5.36%) |
:arrow_down: |
setup.py | 0.00% <ø> (ø) |
|
oguk/calibrate.py | 46.66% <0.00%> (ø) |
|
examples/run_oguk.py | 57.35% <0.00%> (ø) |
|
oguk/tests/test_run_example.py | 93.33% <0.00%> (+60.00%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9155267...99ff935. Read the comment docs.
@jdebacker. This PR is now ready for review. Since the first set of documentation commits described in the first comment of this thread, I made the following changes to the GH Action .yml
files:
has-functional-changes.sh
and is-version-number-acceptable.sh
shell scripts referred to a CONTRIBUTING.md
file that doesn't exist. I changed the reference to CHANGELOG.md
.CHANGELOG.md
.setup.py
.test_frs()
test in the test_get_micro_data.py
module because it was failing in the get_micro_data.get_calculator_output()
method. We should fix this in the future.push.yaml
and pr.yml
files into the current build_and_test.yaml
, check_black.yml
, deploy_docs.yml
, docs_check.yml
, and version_check.yml
examples/plot.py
and get_micro_data.py
Regarding the current set of CI tests:
test_frs()
test in the test_get_micro_data.py
module. This test was failing because of an issue loading the FRS data in the get_micr-Data.get_calculator_output()
method. We should fix this in the future.@jdebacker @nikhilwoodruff. This PR is ready for final review once all tests pass (except for versioning and codecov).
This PR updates the documentation for
OG-UK
, including fixing the references to the United States, U.S. data, and theTax-Calculator
microsimulation model as noted in Issue #44. This PR does the following.OG-USA
toOG-UK
OG-UK-Calibration
OGUK_references.bib
,citations.bib
,OGUK_references.md
, andcitations.md
, and add those two.bib
files in the_config.yml
bibtex_bibfiles:
entry_config.yml
, update the copyright year to 2022, the repo URL, and theconfig:
settings forBibTeX
andmathjax
_toc.yml
_toc.yml
,public_api.rst
,calibrate.rst
,get_micro_data.rst
intro.md
,contributor_guide.md
, andtax_functions.md
cc: @jdebacker @nikhilwoodruff