search

PSLmodels / OG-UK

An overlapping generations model to simulate fiscal policy the United Kingdom.
https://pslmodels.github.io/OG-UK
Other
6 stars 7 forks source link

Update starting values in default params #50

Closed jdebacker closed 2 years ago

jdebacker commented 2 years ago

With the updates starting values in this PR, I was able to successfully run the example script (baseline and reform, through TPI in both cases).

codecov[bot] commented 2 years ago

Codecov Report

Merging #50 (b02bef3) into main (0d14540) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main      #50   +/-   ##
=======================================
  Coverage   70.06%   70.06%           
=======================================
  Files           4        4           
  Lines         147      147           
=======================================
  Hits          103      103           
  Misses         44       44
Flag Coverage Δ
unittests 70.06% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d14540...b02bef3. Read the comment docs.

jdebacker commented 2 years ago

This PR is ready for review @nikhilwoodruff, @rickecon

rickecon commented 2 years ago

LGTM. Thanks @jdebacker. Merging.