PSLmodels / PSL-Infrastructure

The Policy Simulation Library consists of models and modeling tools that share the transparency standards and interoperability criteria set by the PSL-Infrastructure project
https://www.pslmodels.org
Other
18 stars 17 forks source link

Fixing CSS problem in page builder GH action #242

Closed chusloj closed 3 years ago

chusloj commented 3 years ago

@Peter-Metz Regarding the page builder GH action breaking CSS you mentioned in #240, I believe it's because we need to link pandoc to the page.css file. Testing this on my local machine seems to bring the page back to it's normal format.

Peter-Metz commented 3 years ago

Thanks Jacob. How are you able to test this process with the GH Action? The shell script works as is when running it locally so my thought is that it's an issue with the Action.

chusloj commented 3 years ago

The shell script works as is when running it locally

Is what I thought would be true as well, but after running the script locally (today) without linking pandoc to the CSS files, new HTML files with the wrong style were produced. I think something may have have changed in an update to pandoc or some other dependency.

Peter-Metz commented 3 years ago

Thanks Jacob. My guess is that this is a version issue with Pandoc or another package, because the Bash script works fine for me locally. In any case, it seems that #243 will do the trick. Thanks!