Update PSL Catalogue action failing for last 5 days

[rickecon]

The Update PSL Catalogue GitHub action has been failing in PSL-Infrastructure for the last 5 days. I suspect this is because of the new Personal Access Token (PAT) verification required starting on August 13. Looking at the .github/workflows/update_catalog.yml file, the only access issue point I can see is the Commit new changes section at the end starting in line 29.

- name: Commit new changes
      working-directory: ./
      shell: bash -l {0}
      run: |
        git config user.name github-actions
        git config user.email github-actions@github.com
        git add -A
        git commit --allow-empty -m "Update PSL-catalog on $(date +'%Y-%m-%d')"
        git push

I'll check to see if there is an easy PAT line that needs to be added to these lines of code. @jdebacker @Peter-Metz

[rickecon]

Or maybe the GitHub token in secrets has expired? I am not a maintainer, so I cannot check this.

[jdebacker]

@rickecon I think it's because of the repo name change for OG-USA. OG-Core (old OG-USA) has a catalog json file, but the new OG-USA (formerly OG-USA-Calibration) did not. I committed a PSL_catalog.json file to the new OG-USA repo tonight, so I expect the catalog to build one tonights attempt.

[jdebacker]

FYI, I had a comment to the Leadership Council in the Element chat tonight citing the need to have a discussion about cataloging these two models at the 8/24 meeting.

[rickecon]

@jdebacker . Ah. I see. In the build error thread, it is erroring because there is no catalogue file in OG-USA, which used to be OG-USA-Calibration. Thanks.

[jdebacker]

It still errored after I added that, but I had needed to update the README.md to have info references in the json. I think, with a PR I just opened, it should all be good. But we'll see!

On Wed, Aug 18, 2021 at 10:13 PM Richard Evans @.***> wrote:

@jdebacker https://github.com/jdebacker . Ah. I see. In the build error thread https://github.com/PSLmodels/PSL-Infrastructure/runs/3367334797?check_suite_focus=true, it is erroring because there is no catalogue file in OG-USA, which used to be OG-USA-Calibration. Thanks.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/PSLmodels/PSL-Infrastructure/issues/266#issuecomment-901554709, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACRYGFH7B7XVJO4WZL5V4FTT5RSDVANCNFSM5CNGXGYA .

[jdebacker]

@Peter-Metz I'm not seeing my error in the PSL_catalog.json in the OG-USA repo. I've fixed things a few times to address the error messages in the build log for the action to create the catalog, but the latest message is too opaque:

...
GET: https://api.github.com/repos/PSLmodels/microdf/contents/PSL_catalog.json?ref=master 200
56
MISSING DATA: microdf, entry: link_to_webapp, {'start_header': None, 'end_header': None, 'source': None, 'type': None, 'data': None}
57
GET: https://api.github.com/repos/PSLmodels/OG-USA/contents/PSL_catalog.json?ref=master 200
58
MISSING DATA: OG-USA, entry: key_features, {'start_header': None, 'end_header': None, 'source': None, 'type': None, 'data': None}
59
GET: https://api.github.com/repos/PSLmodels/OG-USA/contents/README.md?ref=master 200
60
MISSING DATA: OG-USA, entry: user_changelog, {'start_header': None, 'end_header': None, 'source': None, 'type': None, 'data': None}
61
MISSING DATA: OG-USA, entry: user_changelog_recent, {'start_header': None, 'end_header': None, 'source': None, 'type': None, 'data': None}
62
MISSING DATA: OG-USA, entry: dev_changelog, {'start_header': None, 'end_header': None, 'source': None, 'type': None, 'data': None}
63
GET: https://api.github.com/repos/PSLmodels/OG-USA/contents/README.md?ref=master 200

Any thoughts? My latest read through the OG-USA PSL_catalog.json file showed no broken links.

[Peter-Metz]

Hi @jdebacker and @rickecon, I think the issue is that the sections in the OG-USA readme have changed order, so the catalog builder is getting confused when parsing. Specifically, for the disclaimer section, the end_header of "Using/contributing to OG-USA" was moved up in the readme.

You may want to check that the start_header's and end_header's are still correct for the other sections as well.

[jdebacker]

It looks like I finally fixed this!

Sorry for taking so long! I thought I was holding up the listing of the capital-cost-recovery model, but I still don't see it there. Is this because the mirror in PSL models wasn't updated?

[Peter-Metz]

It looks like I finally fixed this!

Awesome! Looks like those changes were pushed to the catalog.

Is this because the mirror in PSL models wasn't updated?

No this is because the capital-cost-recovery project is missing some sections that are technically required (specifically user_changelog_recent, contributor_overview, and link_to_webapp). I'm not convinced that these sections should be required and could open a PR to the catalog builder that makes them optional. Do you think this warrants further discussion in a new issue?

[jdebacker]

@Peter-Metz if you can make those sections optional, that would be great. I don't think we need to discuss it further. Thanks!

[jdebacker]

Resolved with PR #300