search

PSLmodels / Package-Builder

Policy Simulation Library tool that builds packages and uploads them to the Anaconda Cloud's PSLmodels channel for public distribution
4 stars 7 forks source link

Add --local option to Package-Builder's pbrelease tool and remove --also37 option #158

Closed martinholmer closed 5 years ago

martinholmer commented 5 years ago

This pull request implements an idea offered by @hdoupe: the addition of a --local LOCAL option to the CLI pbrelease tool. Using the new option causes two changes in the way the pbrelease tool works: (1) the tool gets the model source code from the top-level directory of the repository source code tree on your local computer (instead of from a GitHub release), and (2) the tool installs the built package on your local computer as version 0.0.0 of the package (instead of uploading packages to the Anaconda Cloud PSLmodels channel).

@hdoupe may have had other objectives in mind when he suggested this enhancement, but for me the main benefit of this enhancement is that the pbrelease --local option can replace the bash/batch scripts in several repositories that are called conda.recipe/install_local_package.[sh|bat] and conda.recipe/remove_local_package.[sh|bat]. Assuming this enhancement works smoothly, those files can be eliminated and developers can rely instead on a central capability to make local packages.

This pull request also removes the --also37 option and now makes packages for both Python 3.6 and 3.7 for each OS platform.

@MattHJensen @andersonfrailey @codykallen @jdebacker @rickecon

hdoupe commented 5 years ago

@martinholmer I really like your take on the local option. Installing local packages wasn't my objective, but this is a very nice use case.

+1