Closed hdoupe closed 4 years ago
While I was working on this PR, I went ahead and updated the type signatures and doc strings for public methods like adjust
and set_state
.
I also made an API change on the extend
method so that instead of label_to_extend
and label_to_extend_values
the more concise label
and label_values
are used. This will be one of the last breaking API changes now that more of PT's methods besides adjust
and set_state
are being used by other projects.
Updates for edge cases in extend logic when directly using the
extend
method and settinglabel_to_extend_values
.Case 1:
label_to_extend values
is an empty list:Case 2:
label_to_extend_values
are all values greater than the defined values:Case 3: Some extend values are less than the defined values:
>
operator for look ups in theadjust
andextend
method instead of comparing values' indices in theextend_grid
.parse_labels
method for validating label values that are set by the user viaset_state
orextend
.