Closed Peter-Metz closed 4 years ago
The only test that is still failing locally is in test_report.py
and seems to be unrelated to this PR or the Tax-Brain web app
@Peter-Metz I think you just need to update the years here: https://github.com/PSLmodels/Tax-Brain/blob/master/cs-config/cs_config/helpers.py#L58-L60
Thanks @hdoupe. Once this is merged, we'll have to issue a new release, right?
Thanks @hdoupe. Once this is merged, we'll have to issue a new release, right?
Yep.
@Peter-Metz I hit an error when testing this locally. I just opened a PR on your branch with the fix: https://github.com/Peter-Metz/Tax-Brain/pull/1
Thanks @hdoupe for that PR. Good to merge on your end?
Thanks @hdoupe for that PR. Good to merge on your end?
Yep, tests pass locally!
@Peter-Metz I think I have a solution for the bokeh problem. I'll have that up in about half an hour.
@Peter-Metz The fix is live. We don't need the bokeh<2.0.0
pin anymore.
Tests passing for you locally @Peter-Metz ?
yessir @hdoupe
Make changes to code and tests to bring Tax-Brain up to date with Bokeh 2.0.0 and Tax-Calculator 2.9.0.
@hdoupe do we need to do anything to bump the last budget year to 2030? Seems like we're getting the year from Tax-Calc, which makes me think we might be good.
Anything else I'm missing on the C/S side?
cc @andersonfrailey