PSLmodels / Tax-Brain

Tax-Brain is an integrator model for PSL tax models
http://taxbrain.pslmodels.org/
MIT License
8 stars 12 forks source link

Clicking the bottom-left "Tables" result freezes #115

Open MaxGhenis opened 4 years ago

MaxGhenis commented 4 years ago

When I click to open the top two Tax-Brain results (the graph and the Aggregate Results table), it opens smoothly, and the X button closes it smoothly. But the bottom "Tables" result consistently freezes up, both when opening it and when closing it with the top-right X. I've reproduced the behavior in multiple simulation runs.

It also freezes other Tax-Brain tabs if I have them open.

hdoupe commented 4 years ago

Thanks for opening this issue @MaxGhenis. It freezes because it's loading a ton of tables, and it takes a bit for bokeh to load the data and get back to being responsive.

One thing that might help improve responsiveness is to make each table with the bokeh tables widget instead of directly embedding the HTML table:

https://github.com/PSLmodels/Tax-Brain/blob/94c4ab5e4a8ce54600e4ec5c0f10baae7b65a455/cs-config/cs_config/outputs.py#L168-L169