search

PSLmodels / Tax-Brain

Tax-Brain is an integrator model for PSL tax models
http://taxbrain.pslmodels.org/
MIT License
9 stars 14 forks source link

augment these labels #116

Open MattHJensen opened 4 years ago

MattHJensen commented 4 years ago

image

jdebacker commented 3 years ago

@MattHJensen These come from the policy_current_law.json in Tax-Calculator, I believe. It's not clear how to change these label names since these are choices in the ParamTools schema for Tax-Calculator.

If you or @hdoupe can confirm this, I'll move this issue over to the Tax-Calculator repo.

MattHJensen commented 3 years ago

@jdebacker I am ok with that, but it will cause a breaking change in Tax-Calculator so we'll have to manage when a fix gets merged into master. (We could either leave a PR open or perhaps start a 4.0.0 branch.)

When this was discussed in the past (in a Tax-Calculator issue or the PR where these labels were introduced, I believe, that I can't find right now), Martin suggested adding a step in Tax-Brain that augments the Tax-Calculator labels to whatever Tax-Brain wants them to be. This approach makes a lot of sense with me, but I am ok doing it either way.