PSLmodels / Tax-Brain

Tax-Brain is an integrator model for PSL tax models
http://taxbrain.pslmodels.org/
MIT License
9 stars 14 forks source link

Update required version of pandas #173

Closed hdoupe closed 3 years ago

hdoupe commented 3 years ago

I ran into this test failure when deploying a new version of Tax-Brain to Compute Studio:

https://github.com/compute-tooling/compute-studio-publish/pull/124/checks?check_run_id=2196720004#step:9:303

I ran into a similar error when working with @MaxGhenis on publishing a CS app the other day and upgrading pandas resolved the problem.

I'll wait on @andersonfrailey to review before merging this since it affects the main repo.

codecov-io commented 3 years ago

Codecov Report

Merging #173 (233568e) into master (6297c41) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #173   +/-   ##
=======================================
  Coverage   82.12%   82.12%           
=======================================
  Files          21       21           
  Lines        1488     1488           
=======================================
  Hits         1222     1222           
  Misses        266      266           
Flag Coverage Δ
unittests 82.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6297c41...233568e. Read the comment docs.

hdoupe commented 3 years ago

Actually, I updated the CS base image so that it doesn't have pandas installed at all, and the pandas error was resolved.