search

PSLmodels / Tax-Brain

Tax-Brain is an integrator model for PSL tax models
http://taxbrain.pslmodels.org/
MIT License
8 stars 12 forks source link

Read updated puf file name from s3 bucket for cs usage #184

Closed hdoupe closed 2 years ago

hdoupe commented 2 years ago

Thanks for the tip @jdebacker.

Resolves #183

hdoupe commented 2 years ago

Just tested locally and downloaded the correct puf. @andersonfrailey @jdebacker

hdoupe commented 2 years ago

Jupyter book failure should be fixed by this: https://github.com/PSLmodels/Tax-Brain/pull/185

andersonfrailey commented 2 years ago

Remaining test failures should be resolved by #181. Taxcalc changed some of the column names that we're dropped when the automated reports are created and the old names were the cause of the bug.

hdoupe commented 2 years ago

@andersonfrailey looks like tests are passing now. I added a command to the build files here: https://github.com/PSLmodels/Tax-Brain/pull/184/commits/5d8041350593008f2528a4a9ba376c052f5d4ac5

andersonfrailey commented 2 years ago

Thanks for working on this, @hdoupe! Anything else you want added before merging?

hdoupe commented 2 years ago

Thanks for working on this, @hdoupe! Anything else you want added before merging?

Nope, it's ready!

andersonfrailey commented 2 years ago

Merge conflict popped up after merging #186. Looks like it's an easy fix, but I want to be sure. @hdoupe your changes should be the accepted ones, right?

hdoupe commented 2 years ago

@andersonfrailey dang sorry I just saw the message about the merge conflict. It's resolved now.

hdoupe commented 2 years ago

Nvmd, looks like there's an issue with the bokeh plots returned by json_item. I hope Bokeh didn't change that data format...checking this out now.

cc @jdebacker sounds similar to your issue with ccc

codecov-commenter commented 2 years ago

Codecov Report

Merging #184 (c3361a8) into master (180063a) will decrease coverage by 0.18%. The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   82.15%   81.97%   -0.19%     
==========================================
  Files          21       21              
  Lines        1547     1648     +101     
==========================================
+ Hits         1271     1351      +80     
- Misses        276      297      +21
Flag Coverage Δ
unittests 81.97% <80.00%> (-0.19%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
taxbrain/report.py 86.92% <44.44%> (-3.33%) :arrow_down:
cs-config/cs_config/helpers.py 47.78% <50.00%> (+0.25%) :arrow_up:
taxbrain/taxbrain.py 89.41% <82.10%> (-3.37%) :arrow_down:
taxbrain/tests/test_brain.py 94.25% <100.00%> (+0.50%) :arrow_up:
taxbrain/utils.py 92.89% <100.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a754de0...c3361a8. Read the comment docs.