PSLmodels / Tax-Brain

Tax-Brain is an integrator model for PSL tax models
http://taxbrain.pslmodels.org/
MIT License
9 stars 14 forks source link

Question about dependencies in conda.recipe/meta.yaml #20

Closed martinholmer closed 5 years ago

martinholmer commented 5 years ago

@hdoupe and @andersonfrailey, I don't understand the following Tax-Brain requirements specification:

requirements:
  build:
    - python
    - "taxcalc>1.0.0"
    - "behresp>=0.6.0"
    - "pandas>=0.23"
    - dask
    - "numpy>=1.13"

  run:
    - python
    - "taxcalc>1.0.0"
    - "behresp>=0.6.0"
    - "pandas>=0.23"
    - dask
    - "numpy>=1.13"

Can't you drop out the pandas and numpy lines from both sets of dependencies? It would seem that they are redundant (and could cause dependency conflicts in the future) because taxcalc already lists pandas and numpy as requirements. Certainly, the behresp packages, which make use of both numpy and pandas, are made just fine with using this pared-down set of requirements:

requirements:
  build:
    - python
    - "taxcalc>=1.0"

  run:
    - python
    - "taxcalc>=1.0"
andersonfrailey commented 5 years ago

@martinholmer, you're right. I've dropped the pandas and numpy requirements in PR #18.

martinholmer commented 5 years ago

@andersonfrailey said:

I've dropped the pandas and numpy requirements in PR #18.

OK. Good.