search

PSLmodels / Tax-Brain

Tax-Brain is an integrator model for PSL tax models
http://taxbrain.pslmodels.org/
MIT License
8 stars 12 forks source link

Allow for more flexible microdata inputs #202

Closed jdebacker closed 3 weeks ago

jdebacker commented 1 month ago

This PR adds functionality to make it straightforward for users to use the CPS, PUF, and TMD files that Tax-Calculator is compatible with. It also preserves the ability to include a custom data file, but adds arguments to pass custom grow factors and weights with the data.

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 35.37415% with 95 lines in your changes missing coverage. Please review.

Project coverage is 79.50%. Comparing base (8b9fba3) to head (782931e).

Files Patch % Lines
taxbrain/taxbrain.py 31.70% 56 Missing :warning:
cs-config/cs_config/helpers.py 11.11% 16 Missing :warning:
cs-config/cs_config/functions.py 25.00% 15 Missing :warning:
taxbrain/tests/test_brain.py 70.83% 7 Missing :warning:
setup.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #202 +/- ## ========================================== - Coverage 83.13% 79.50% -3.63% ========================================== Files 23 23 Lines 1844 1947 +103 ========================================== + Hits 1533 1548 +15 - Misses 311 399 +88 ``` | [Flag](https://app.codecov.io/gh/PSLmodels/Tax-Brain/pull/202/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PSLmodels/Tax-Brain/pull/202/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | `79.50% <35.37%> (-3.63%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jdebacker commented 1 month ago

@andersonfrailey This PR is ready for review. I'd appreciate if you could look over my changes to the API to make sure there's nothing Tax-Brain would lose from my proposed changes.