search

PSLmodels / Tax-Brain

Tax-Brain is an integrator model for PSL tax models
http://taxbrain.pslmodels.org/
MIT License
9 stars 14 forks source link

Refactor TBI to work with new COMP requirements #38

Closed andersonfrailey closed 5 years ago

andersonfrailey commented 5 years ago

This PR is meant to bring Tax-Brain's TBI output inline with COMP's new output format. Right now, the TBI returns a dictionary full of tables and tags that COMP then processes. Now it will return a dictionary with a Bokeh layout that contains all of those outputs.

cc @hdoupe

hdoupe commented 5 years ago

Looks good @andersonfrailey. I'm working on some preliminary automated testing for the inputs and outputs formats. If you're willing to be a guinea pig, we can try that out on the new outputs before you do a release.

andersonfrailey commented 5 years ago

@hdoupe always down to guinea pig COMP. Let me know what needs to be done on my end.

hdoupe commented 5 years ago

Awesome, thanks. I'll have something for you tomorrow.

andersonfrailey commented 5 years ago

Latest commits add a compconfig directory. This will replace the TBI as the interface between COMP and Tax-Brain. All of the functions in the TBI have been moved to this directory. Additionally, the functions to get the default values, validate user input, and run the model have been changed to work with the new COMP workflow. See compconfig/compconfig/functions.py for details.

A later commit will remove the TBI from the repository.

cc @hdoupe

andersonfrailey commented 5 years ago

Latest commit removes all of the TBI files. I've also updated the tests to work with Tax-Calculator 2.0.0.