search

PSLmodels / Tax-Brain

Tax-Brain is an integrator model for PSL tax models
http://taxbrain.pslmodels.org/
MIT License
9 stars 14 forks source link

Add data_source label #60

Closed andersonfrailey closed 5 years ago

andersonfrailey commented 5 years ago

This PR adds data_source to the list of possible labels. This will hopefully solve #59.

cc @hdoupe

hdoupe commented 5 years ago

Looks good to me @andersonfrailey. You may want to add a test for a parameter that is only available for one of the data sets. This reform causes a crash:

{
    "policy": {
        "BEN_ssi_repeal": [
            {
                "year": 2019,
                "value": true,
                "data_source": "CPS"
            }
        ]
    },
    "behavior": {}
}

You could add the benefit parameter to this test so it wouldn't have any significant effects on the run time of the compconfig tests.

andersonfrailey commented 5 years ago

Good idea, @hdoupe. Added in the latest commit.

hdoupe commented 5 years ago

LGTM!