PSLmodels / Tax-Brain

Tax-Brain is an integrator model for PSL tax models
http://taxbrain.pslmodels.org/
MIT License
9 stars 14 forks source link

COMP Dev Kit Test Failure #70

Closed andersonfrailey closed 5 years ago

andersonfrailey commented 5 years ago

When I run the test suite, the COMP tests are currently failing with is output:

    def _run_validator(
        self,
        validator_func,
        output,
        *,
        original_data,
        fields_dict,
        error_store,
        many,
        partial,
        pass_original,
        index=None
    ):
        try:
            if pass_original:  # Pass original, raw data (before unmarshalling)
                validator_func(output, original_data, partial=partial, many=many)
            else:
>               validator_func(output, partial=partial, many=many)
E               TypeError: validate_params() got an unexpected keyword argument 'partial'

../anaconda/envs/taxbrain-dev/lib/python3.6/site-packages/marshmallow/schema.py:777: TypeError

and

    def _run_validator(
        self,
        validator_func,
        output,
        *,
        original_data,
        fields_dict,
        error_store,
        many,
        partial,
        pass_original,
        index=None
    ):
        try:
            if pass_original:  # Pass original, raw data (before unmarshalling)
                validator_func(output, original_data, partial=partial, many=many)
            else:
>               validator_func(output, partial=partial, many=many)
E               TypeError: validate_params() got an unexpected keyword argument 'partial'

../anaconda/envs/taxbrain-dev/lib/python3.6/site-packages/marshmallow/schema.py:777: TypeError

It looks like this might just be an issue with my marshmallow version though since both errors are traced back to marshmallow/schema.py. I'm currently using version 3.0.0rc8.

cc @hdoupe

hdoupe commented 5 years ago

Yep, this seems like an issue with marshmallow 3.0.0rc7 or 3.0.0rc8. I'm getting similar errors with the paramtools tests. It looks like they just some work on args like partial in release 3.0.0rc7. I'll take a look at this.

hdoupe commented 5 years ago

@andersonfrailey Installing ParamTools 0.7.2 should resolve this problem (#70).

hdoupe commented 5 years ago

@andersonfrailey is #70 resolved?

andersonfrailey commented 5 years ago

@hdoupe yep! Closing.