PSLmodels / Tax-Brain

Tax-Brain is an integrator model for PSL tax models
http://taxbrain.pslmodels.org/
MIT License
9 stars 14 forks source link

Filter unsectioned Tax-Calc params from C/S #89

Closed Peter-Metz closed 4 years ago

Peter-Metz commented 4 years ago

Following discussion in Tax-Calc #2374, this PR filters out the unsectioned Tax-Calculator parameters in the Tax-Brain web app

cc: @andersonfrailey @hdoupe

Peter-Metz commented 4 years ago

As an FYI, some of the tests are failing because of (I believe) issues unrelated to this PR. I'm happy to close this PR for now or just hold off on merging until we sort the tests out.

hdoupe commented 4 years ago

@Peter-Metz #89 looks good. Do the tests pass locally with the updated environment in PR #91?

Peter-Metz commented 4 years ago

@hdoupe yep, the tests are passing locally with the exception of test_report (unrelated to this PR -- it's not properly exporting the png file). I'll poke around and try to get that test passing and open a separate PR. I think this one is good to be merged.

hdoupe commented 4 years ago

Cool, thanks @Peter-Metz!