search

PSLmodels / Tax-Calculator

USA Federal Individual Income and Payroll Tax Microsimulation Model
https://taxcalc.pslmodels.org
Other
262 stars 157 forks source link

Pandas .append() method deprecated #2679

Closed bodiyang closed 1 year ago

bodiyang commented 1 year ago

Have the following issues when doing local testing for a PR work.

The testing warning indicates pandas .append() method (dataframe) is deprecated, and needs to be replaced with .concat() method. This change is also documented by Pandas

taxcalc/tests/test_utils.py::test_dist_table_sum_row
taxcalc/tests/test_utils.py::test_dist_table_sum_row
taxcalc/tests/test_utils.py::test_create_tables
  /Users/bodiyang/Desktop/taxcalc/Tax-Calculator/taxcalc/utils.py:383: FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.
    dist_table = dist_table.append(sum_row)

Also the git actions tests is showing error message

Tax-Calculator may need the corresponding changes for this.

bodiyang commented 1 year ago

to be solved in PR 2676