PSLmodels / Tax-Calculator

USA Federal Individual Income and Payroll Tax Microsimulation Model
https://taxcalc.pslmodels.org
Other
255 stars 154 forks source link

Eitc paramfix #2699

Closed bodiyang closed 11 months ago

bodiyang commented 11 months ago

This PR fix the EITC_ps_MarriedJ parameter value for the year 2020

The EITC_ps_MarriedJ value for the year 2020 should be $5890, as from the IRS publication

codecov[bot] commented 11 months ago

Codecov Report

Merging #2699 (4c54366) into master (0ce7072) will not change coverage. Report is 2 commits behind head on master. The diff coverage is n/a.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2699/graphs/tree.svg?width=650&height=150&src=pr&token=KqtTvRSNjQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels)](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2699?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) ```diff @@ Coverage Diff @@ ## master #2699 +/- ## ======================================= Coverage 98.54% 98.54% ======================================= Files 14 14 Lines 2609 2609 ======================================= Hits 2571 2571 Misses 38 38 ``` | [Flag](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2699/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/PSLmodels/Tax-Calculator/pull/2699/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels) | `98.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=PSLmodels#carryforward-flags-in-the-pull-request-comment) to find out more.
bodiyang commented 11 months ago

@jdebacker I've had all local tests pass. online tests look ok with ubuntu-latest tests all pass, but windows-latest is showing the codecov uploading issue again ~ maybe can try to rerun the test?

jdebacker commented 11 months ago

@bodiyang Thanks for this fix. I confirm the changed number also in the TPC publication of EITC parameters.

I've restarted the test that failed to upload to CodeCov.

jdebacker commented 11 months ago

This PR LGTM. Will merge on Wednesday if not other comments before then.